Open
Conversation
Contributor
Author
|
Random thought: We can put the manual testing setup in the conanfile.py so we have it on CI. However, I'd like it to be done properly later on (maybe |
Contributor
|
I have merged #62 and #63, because they were quick to review. This PR can be viewed as a change on top of those. Regarding your RFC points:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though #62 and #63 are up for review already, I'd also like to submit my take on adding CI to the ICD loader, since this is in use successfully over at bincrafters/conan-khronos-opencl-icd-loader already for generating ICD binary artifacts.
This matrix uses the Conan Package Tools to build significantly more configurations:
Since almost all permutations of above matrix are built, this sums up to >150 builds and should give us a very nice coverage.
RFC